smpp, cimd2 support for expired DLR

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

smpp, cimd2 support for expired DLR

Marcin-36
Hi,

Please take a look on smpp and cimd2 patch so now those protocols can support DLR_EXPIRED.

Best regards
Marcin 'Iwan' K-k.

kannel_smpp_cimd2_expiration.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: smpp, cimd2 support for expired DLR

amalysh
Hi,

patch looks mostly ok except this part:

+    if ( dlr_mask < -1 || dlr_mask > 255 ) { /* 11111111 */

Why 255 ? 

Max dlr-msk what we have:
#define DLR_UNKNOWN         0x40|DLR_FAIL

=> 66

Please fix and if no objections I will commit it.

Thanks,
Alex


Am 02.10.2016 um 21:07 schrieb Iwan Iwanowicz <[hidden email]>:

Hi,

Please take a look on smpp and cimd2 patch so now those protocols can support DLR_EXPIRED.

Best regards
Marcin 'Iwan' K-k.
<kannel_smpp_cimd2_expiration.patch>

Reply | Threaded
Open this post in threaded view
|

Re: smpp, cimd2 support for expired DLR

Marcin-36
Hi, 
Thanks for review. 
Fixed version in attachment.

Best regards
Marcin 'Iwan' K-k

2016-10-26 16:43 GMT+02:00 <[hidden email]>:
Hi,

patch looks mostly ok except this part:

+    if ( dlr_mask < -1 || dlr_mask > 255 ) { /* 11111111 */

Why 255 ? 

Max dlr-msk what we have:
#define DLR_UNKNOWN         0x40|DLR_FAIL

=> 66

Please fix and if no objections I will commit it.

Thanks,
Alex


Am 02.10.2016 um 21:07 schrieb Iwan Iwanowicz <[hidden email]>:

Hi,

Please take a look on smpp and cimd2 patch so now those protocols can support DLR_EXPIRED.

Best regards
Marcin 'Iwan' K-k.
<kannel_smpp_cimd2_expiration.patch>



kannel_smpp_cimd2_expiration.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: smpp, cimd2 support for expired DLR

amalysh
Hi,

thanks, commited to SVN.

Thanks,
Alex


Iwan Iwanowicz <[hidden email]> schrieb am So., 30. Okt. 2016 um 17:36 Uhr:
Hi, 
Thanks for review. 
Fixed version in attachment.

Best regards
Marcin 'Iwan' K-k

2016-10-26 16:43 GMT+02:00 <[hidden email]>:
Hi,

patch looks mostly ok except this part:

+    if ( dlr_mask < -1 || dlr_mask > 255 ) { /* 11111111 */

Why 255 ? 

Max dlr-msk what we have:
#define DLR_UNKNOWN         0x40|DLR_FAIL

=> 66

Please fix and if no objections I will commit it.

Thanks,
Alex


Am 02.10.2016 um 21:07 schrieb Iwan Iwanowicz <[hidden email]>:

Hi,

Please take a look on smpp and cimd2 patch so now those protocols can support DLR_EXPIRED.

Best regards
Marcin 'Iwan' K-k.
<kannel_smpp_cimd2_expiration.patch>