How to get charset patches accepted for CVS

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

How to get charset patches accepted for CVS

Hillel-5
Dear Kannel CVS Maintainers,

On Date: Fri, 20 Jan 2006 Peter Christensen send in his alpa_gsm patch with
changes requested by Alexander Malysh to allow one to send different chars
in the senderid (address of the SMS) and body of the SMS, the Subject of the
email was "Re: user guide". He also sent in previously his cp1252 patch
which work together with his alpa_gsm patch.

For our company the ideal would be to replace the @ with a space as this
makes the problem with the @ in the senderid (SMS address) less obvious to
the recipient of the SMS, but we will also be fine with a ?. So if the
Kannel CVS maintainers want to go with a ? that is OK.

Are there any other comments or issues so that Peter can improve his
patches?

Otherwise, Please can they be added to CVS and to the user guide, as we are
doing some development that requires this patch and would prefer to use it
via CVS. I'm sure there are others who would also like to send different
types of characters via Kannel in the SMS.

Some developers give up when changes are requested.  Peter has done a lot of
work into making his patches acceptable to Kannel CVS, which should count in
a developers favour.

Thanks



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: How to get charset patches accepted for CVS

amalysh
Hi,

thanks for reminder but unfortunately we all have our daily jobs so
please be a bit patiently.

I hope to find some time today to commit this patch.

Thanks,
Alex

Hillel schrieb:

> Dear Kannel CVS Maintainers,
>
> On Date: Fri, 20 Jan 2006 Peter Christensen send in his alpa_gsm patch with
> changes requested by Alexander Malysh to allow one to send different chars
> in the senderid (address of the SMS) and body of the SMS, the Subject of the
> email was "Re: user guide". He also sent in previously his cp1252 patch
> which work together with his alpa_gsm patch.
>
> For our company the ideal would be to replace the @ with a space as this
> makes the problem with the @ in the senderid (SMS address) less obvious to
> the recipient of the SMS, but we will also be fine with a ?. So if the
> Kannel CVS maintainers want to go with a ? that is OK.
>
> Are there any other comments or issues so that Peter can improve his
> patches?
>
> Otherwise, Please can they be added to CVS and to the user guide, as we are
> doing some development that requires this patch and would prefer to use it
> via CVS. I'm sure there are others who would also like to send different
> types of characters via Kannel in the SMS.
>
> Some developers give up when changes are requested.  Peter has done a lot of
> work into making his patches acceptable to Kannel CVS, which should count in
> a developers favour.
>
> Thanks
>
>
>
>


Loading...